Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update database download commands to use curl -JLO #2038

Merged
merged 3 commits into from
May 13, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 6, 2022

Fixes #2035 by providing curl instructions that will make use of the server-side filename.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #2038 (6ceb54a) into latest (7d333d5) will increase coverage by 7.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2038      +/-   ##
==========================================
+ Coverage   84.15%   91.67%   +7.52%     
==========================================
  Files         129       98      -31     
  Lines       15087    10807    -4280     
  Branches     2119     2119              
==========================================
- Hits        12696     9907    -2789     
+ Misses       2095      604    -1491     
  Partials      296      296              
Flag Coverage Δ
python 91.67% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/sketch/minhash.rs
src/core/tests/test.rs
src/core/src/index/bigsi.rs
src/core/src/ffi/index/revindex.rs
src/core/src/from.rs
src/core/src/signature.rs
src/core/src/ffi/utils.rs
src/core/src/errors.rs
src/core/src/ffi/nodegraph.rs
src/core/src/sketch/nodegraph.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d333d5...6ceb54a. Read the comment docs.

@ctb ctb merged commit 6c7b3a8 into latest May 13, 2022
@ctb ctb deleted the update/db_download branch May 13, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update databases page to suggest curl -JLO
2 participants